Fix distorted TV episode posters. Add client-side progress bar and played indicator. #922
Conversation
prevents distoring images in episode listing
ApexArray
changed the title
|
What if we changed the poster size to be 16:9 aspect ratio and used |
|
I considered that as well, but I figured it was best to default to the same behavior in jellyfin-web. It looks like they’re cropping the image and adding a custom icon/progress bar. |
render these client side to ensure they fit in custom image size
ApexArray
changed the title
| <Rectangle id="playedIndicator" color="#00a4dcFF" width="60" height="46" visible="false" translation="[290, 0]"> | ||
| <Label id="checkmark" width="60" height="42" font="font:SmallestBoldSystemFont" horizAlign="center" vertAlign="bottom" text="✓"/> | ||
| </Rectangle> | ||
| <Rectangle id="progressBackground" visible="false" color="0x00000098" width="350" height="16" translation="[0,286]"> |
There was a problem hiding this comment.
Can we make the height 8 to match the homepage bar height?
There was a problem hiding this comment.
At a height of 8, the row selector blocks a good chunk of the progress bar. Do we want to stick with this height, or try to move/resize the progress bar on selection?
| <LayoutGroup id="main_group" layoutDirection="horiz" itemSpacings="[30]"> | ||
| <Poster id="poster" width="350" height="300" loadDisplayMode="scaleToZoom"> | ||
| <Rectangle id="playedIndicator" color="#00a4dcFF" width="60" height="46" visible="false" translation="[290, 0]"> | ||
| <Label id="checkmark" width="60" height="42" font="font:SmallestBoldSystemFont" horizAlign="center" vertAlign="bottom" text="✓"/> |
There was a problem hiding this comment.
Let's bump up the font size on the check to 35.
Here's what it looks like.
There was a problem hiding this comment.
Is there a way to override font size here? Couldn't find a way to do that, so I've set it over in the TVListDetails.brs init funciton.
|
To be merged 1/27 unless an issue arises. |
Changes
✔ Sets
loadDisplayMode="scaleToZoom"on TV episode posters to avoid squashing the image.✔ Removes
AddPlayedIndicatorandPercentPlayedparameters when retrieving episode images.✔ Renders client-side progress bar (inspired by the
HomeItemcomponent)✔ Renders client-side "played" indicator (inspired by @1hitsong's pr #882)
Before and after:
Issues
Fixes #603
Should also improve performance and free up texture memory, since we don't need to call/store a separate image with playback info overlay.